[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.
Vy Nguyen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 2 11:12:09 PST 2021
oontvoo created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun, mgorny.
oontvoo requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Using XCTAssertEqual on NSString* objects are almost always wrong.
Unfortunatley, we have seen a lot of tests doing this and reyling on pointer equality for strings with the same values.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D114975
Files:
clang-tools-extra/clang-tidy/objc/AssertEquals.cpp
clang-tools-extra/clang-tidy/objc/AssertEquals.h
clang-tools-extra/clang-tidy/objc/CMakeLists.txt
clang-tools-extra/clang-tidy/objc/ObjCTidyModule.cpp
clang-tools-extra/docs/clang-tidy/checks/list.rst
clang-tools-extra/test/clang-tidy/checkers/Inputs/objc-assert/XCTestAssertions.h
clang-tools-extra/test/clang-tidy/checkers/objc-assert-equals.m
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114975.391402.patch
Type: text/x-patch
Size: 10525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211202/e886a5ae/attachment.bin>
More information about the cfe-commits
mailing list