[PATCH] D112626: Convert float to double on __builtin_dump_struct

Rafael Franco via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 11:00:41 PST 2021

rafaelfranco added a comment.

Hey all! Thanks for taking the time to review my patch and writing the Compiler Explorer examples and everything. I had no idea this was the essentially the wrong approach to this, I'd be happy to do a bigger overhaul of the whole builtin if that would make it more correct, but as Aaron points out I'm very new to this project (and C++ too) and essentially clueless as to how to do that, I submitted this patch because it looked like it was simple enough to issue the fpext to get the float promoted.
If you give me some pointers I'd be more than happy to give it a shot, I should have time in the coming weeks. As a seasoned printf debugger 😄 this builtin is pretty useful to me and I'd like to fix it rather than deprecating or otherwise removing it.
As for the static map, it looks to me like it would be fairly straightforward to replace it with a simple helper function?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list