[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 10:59:52 PST 2021


jansvoboda11 added a comment.

Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files.

Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most likely to avoid inconsistencies when the file changes on the filesystem between stat and read. Is that correct, @arphaman? If so, I think I should abandon this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114968/new/

https://reviews.llvm.org/D114968



More information about the cfe-commits mailing list