[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 09:21:05 PST 2021


kbobyrev added a comment.

In D113898#3167050 <https://reviews.llvm.org/D113898#3167050>, @kuhnel wrote:

> Looking at the documentation, this looks like a bug in the clang-tidy check:
> https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html
>
> The rule `llvm-qualified-auto` should not add a `const` qualifier.

I don't see how that is a bug: the docs specially cover the `const auto *` conversion in the first example by drawing the line between `observe()` (non-mutating function) and `change()` (possibly mutating function).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113898/new/

https://reviews.llvm.org/D113898



More information about the cfe-commits mailing list