[PATCH] D113896: [clangd] cleanup of header guard names
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 2 08:49:31 PST 2021
kadircet added a comment.
> This looks to be a deliberate decision: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h#L32
> Looking at the code under `clang/include`, it looks like most headers don't have the `#endif // COMMENT`, so this might be correct. However, the style guide is rather vague and doesn't mention this at all: https://llvm.org/docs/CodingStandards.html#header-guard
ah right, I was looking at https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp#L289, which happens to be the base class. thanks!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits