[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

Thu Dec 2 08:01:42 PST 2021

aaron.ballman added a comment.

In D114688#3166870 <https://reviews.llvm.org/D114688#3166870>, @junaire wrote:

> I didn't know if I understand Aaron's words right, but I think I can update the patch first...

I think you understood my suggestion pretty well, thanks!

================
Comment at: clang/lib/Sema/SemaChecking.cpp:2107
+
+    auto CheckArgType = [this](CallExpr *TheCall) -> bool {
+      QualType ArgTy = TheCall->getArg(0)->getType();
----------------
I don't think using a lambda here (or below) adds a whole lot of value given that it's only called once. I think it'd cleaner to hoist the lambda logic into the case block directly. WDYT?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114688/new/

https://reviews.llvm.org/D114688