[PATCH] D113896: [clangd] cleanup of header guard names
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 2 07:47:31 PST 2021
kbobyrev added a comment.
Also, please mention the
In D113896#3166732 <https://reviews.llvm.org/D113896#3166732>, @kuhnel wrote:
> @kadircet looks like clang-tidy does not detect missing comments in `#endif`. It does complain about missing comments for namespaces. E.g. in `Serialization.h` the `#endif` comment is missing, but without a finding.
This looks to be a deliberate decision: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h#L32
Looking at the code under `clang/include`, it looks like most headers don't have the `#endif // COMMENT`, so this might be correct. However, the style guide is rather vague and doesn't mention this at all: https://llvm.org/docs/CodingStandards.html#header-guard
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits