[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

Bal√°zs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 06:30:26 PST 2021


steakhal added a comment.

In D114887#3165415 <https://reviews.llvm.org/D114887#3165415>, @martong wrote:

> In D114887#3165397 <https://reviews.llvm.org/D114887#3165397>, @steakhal wrote:
>
>> Also, please provide the coverage of the new test case (only excercising the new test case not the whole test file) I really want to make sure that it will cover the loop as it supposed to.
>>
>> Oh, I just now see that there is no test. Now I'm really courious.
>
> There is a test case in D103317 <https://reviews.llvm.org/D103317> (with the so many `b`s) which covers the loop. That patch is the dependent patch of the reverted patch.

I'm still curious to see which lines are covered by tests.
Pragmatically, this patch changes some behavior, thus we need to know what lines become uncovered due to this change.
I suspect it won't change much, but better be on the safe side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114887/new/

https://reviews.llvm.org/D114887



More information about the cfe-commits mailing list