[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 05:35:19 PST 2021


aaron.ballman added a comment.

In D114809#3166602 <https://reviews.llvm.org/D114809#3166602>, @ymandel wrote:

> In D114809#3165214 <https://reviews.llvm.org/D114809#3165214>, @aaron.ballman wrote:
>
>> LGTM! I had no idea...
>>
>> (As a follow-up question, should we be removing the `using` declarations starting around line 141 or so? Many of them are not used, and if the documentation dumper can't look through typedefs and gets the documentation wrong, perhaps we want to discourage using them entirely?)
>
> Aaron -- at least in our codebase, those are used a fair amount. What about updating the script to understand those typedefs?

That would also be an effectively solution! I was assuming it would be difficult to update the script.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114809/new/

https://reviews.llvm.org/D114809



More information about the cfe-commits mailing list