[PATCH] D113896: [clangd] cleanup of header guard names

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 02:51:30 PST 2021


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/PathMapping.h:2
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H
+
----------------
Please move the header guard after the comment like we do in the other files.


================
Comment at: clang-tools-extra/clangd/PathMapping.h:72
+
+#endif
----------------
Please add a closing comment (`// LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H`)


================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.h:1
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_UNITTESTS_LSPCLIENT_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_UNITTESTS_LSPCLIENT_H
----------------
Please move the header guard after the comment like we do in the other files.


================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.h:87
+
+#endif
----------------
Also needs a closing comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113896/new/

https://reviews.llvm.org/D113896



More information about the cfe-commits mailing list