[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 1 13:18:36 PST 2021

vsapsai added a comment.

After more testing and thinking I've realized we are still not handling anonymous enums properly. On one hand anonymous EnumDecl aren't duplicates and we aren't making a hidden EnumDecl + EnumConstantDecl visible and don't have ambiguity problems. On the other hand, when we do make them visible through explicit import, we are hitting ambiguous references again.

Need to check the previous discussions and see if can bring ObjC/C closer to C++ in context of handling these duplicates. In ASTReaderDecl I was trying to keep ObjC/C support similar to C++ (modulo templates) and it turned out to be better for comprehension.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list