[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 1 11:43:09 PST 2021

erichkeane added a comment.

>> I think the safest bet is to be conservative and not allow mixing packs with variadics, and not allowing multiple packs. We should be able to diagnose that situation from ClangAttrEmitter.cpp to help attribute authors out. However, it'd be worth adding a FIXME comment to that diagnostic logic asking whether we want to relax the behavior at some point. But if you feel strongly that we should support these situations initially, I wouldn't be opposed.

>From a practical perspective, the only difference between a list of `ExprArgument` and `VariadicExprArgument` is the enforced arity.... I would also consider seeing if we can just generalize the pack logic to work for BOTH cases.  I'd be all for limiting the pack/ExprArgument list to be the 'last' argument to simplify it.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list