[libunwind] dc1244d - [runtimes] Move WARNING to FATAL_ERROR for folks using FOO_BUILD_32_BITS

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 1 09:58:00 PST 2021


Author: Louis Dionne
Date: 2021-12-01T12:57:30-05:00
New Revision: dc1244dc4e76316ab24596545951d3dc47359875

URL: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875
DIFF: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875.diff

LOG: [runtimes] Move WARNING to FATAL_ERROR for folks using FOO_BUILD_32_BITS

Added: 
    

Modified: 
    libcxx/CMakeLists.txt
    libcxxabi/CMakeLists.txt
    libunwind/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt
index 9670d93e3d981..b28dd00f6159a 100644
--- a/libcxx/CMakeLists.txt
+++ b/libcxx/CMakeLists.txt
@@ -263,7 +263,7 @@ option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
 # Target options --------------------------------------------------------------
 option(LIBCXX_BUILD_32_BITS "Build 32 bit multilib libc++. This option is not supported anymore when building the runtimes. Please specify a full triple instead." ${LLVM_BUILD_32_BITS})
 if (LIBCXX_BUILD_32_BITS)
-  message(WARNING "LIBCXX_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
+  message(FATAL_ERROR "LIBCXX_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
 endif()
 
 if(CMAKE_CXX_COMPILER_TARGET)

diff  --git a/libcxxabi/CMakeLists.txt b/libcxxabi/CMakeLists.txt
index 0d513884ed4d7..12bcd2eee0996 100644
--- a/libcxxabi/CMakeLists.txt
+++ b/libcxxabi/CMakeLists.txt
@@ -110,7 +110,7 @@ option(LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS
    which case the definition in libc++abi should be turned off." ON)
 option(LIBCXXABI_BUILD_32_BITS "Build 32 bit multilib libc++abi. This option is not supported anymore when building the runtimes. Please specify a full triple instead." ${LLVM_BUILD_32_BITS})
 if (LIBCXXABI_BUILD_32_BITS)
-  message(WARNING "LIBCXXABI_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
+  message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
 endif()
 
 option(LIBCXXABI_INCLUDE_TESTS "Generate build targets for the libc++abi unit tests." ${LLVM_INCLUDE_TESTS})

diff  --git a/libunwind/CMakeLists.txt b/libunwind/CMakeLists.txt
index 3727d11598366..a63dc453ffb6c 100644
--- a/libunwind/CMakeLists.txt
+++ b/libunwind/CMakeLists.txt
@@ -59,7 +59,7 @@ include(HandleCompilerRT)
 # Define options.
 option(LIBUNWIND_BUILD_32_BITS "Build 32 bit multilib libunwind. This option is not supported anymore when building the runtimes. Please specify a full triple instead." ${LLVM_BUILD_32_BITS})
 if (LIBUNWIND_BUILD_32_BITS)
-  message(WARNING "LIBUNWIND_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
+  message(FATAL_ERROR "LIBUNWIND_BUILD_32_BITS is not supported anymore when building the runtimes, please specify a full triple instead.")
 endif()
 
 option(LIBUNWIND_ENABLE_CET "Build libunwind with CET enabled." OFF)


        


More information about the cfe-commits mailing list