[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

Wed Dec 1 06:18:40 PST 2021

zahiraam added a comment.

In D114099#3148665 <https://reviews.llvm.org/D114099#3148665>, @zahiraam wrote:

> In D114099#3148631 <https://reviews.llvm.org/D114099#3148631>, @sylvestre.ledru wrote:
>
>> Actually, it breaks on all Debian.
>> Could you please revert it?
>
> Done.

I have reverted this patch but would like to push it in at some point (may be after the back end changes https://reviews.llvm.org/D107082 will be merged in.
But I see in the command above that it is compiling with -DCOMPILER_RT_HAS_FLOAT16. @sylvestre.ledru is this flag really supposed to be on? Was it the case before this patch? @rjmccall isn't this because we turned on HasLegalHalfType?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114099/new/

https://reviews.llvm.org/D114099