[PATCH] D111566: [SYCL] Fix function pointer address space
Dylan McKay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 1 01:18:03 PST 2021
dylanmckay accepted this revision.
dylanmckay added a comment.
By the way, as this has already been approved by one, and you rightly applied the "speak now or forever hold your peace" principle re. OpenCL, and this clearly works better from my point of view than the old code, I wouldn't want to prevent you from committing this. **I have no objections to merging this in its current state**. If you do merge it as-is though it would be nice if a follow up PR moves the logic into `getTargetAddressSpace()` where I think it better belongs
CHANGES SINCE LAST ACTION
More information about the cfe-commits