[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

| 1658 | remove           | NULL                                     |
| 1731 | std::__u::remove | llvm/include/c++/v1/__algorithm/remove.h |
|

for whatever reason I remembered the std::remove to have been referenced ~17k. looks like these two are much closer. I don't think it makes sense to prefer one or the other here.

I suggest moving forward with a mechanism that enables accepting certain variants and accepting both unnamed and algorithm variants for std::remove, hence it being rejected as an ambiguous symbol in the end. That way we won't have a special case to handle once we start including multiple options for a symbol.
WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114724/new/

https://reviews.llvm.org/D114724