[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 14:42:41 PST 2021

RKSimon added a comment.

In D114639#3162157 <https://reviews.llvm.org/D114639#3162157>, @mehdi_amini wrote:

> In D114639#3162141 <https://reviews.llvm.org/D114639#3162141>, @erichkeane wrote:
>>> Right, but last time we did the motivation was specifically to get to c++14, while here the motivation is to drop an old MSVC according to the MSVC-specific support we intend to provide.
>> My memory is that that was _A_ motivation, not the only one.  There were quite a few GCC bugs that we were getting away from as well that was my primary justification for pushing it at the time, though the C++14 motivation was ALSO tempting/appreciated.
> I'm fairly sure that at least JF who pushed for it was motivated by C++14, here is the RFC: https://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html
> The update of toolchain has always historically been measured by the amount of features we get from the update, in particular while compilers were getting support for new standard feature during C++11 adoption it was really a game of matching the various compiler, looks at potential updates and what this would enable. Though I agree that we're somehow frequently working around issues specific to gcc-5 (I'd say my gcc-5.4 bot breaks once a week on average), and migrating from old toolchains can have value on its own.

I'd be happy to coordinate with others if they can create patches for the respective compiler bumps, but my ability to test the many permutations of linux distros + gcc is quite limited (currently x64 ubuntu 18.04 desktop + ubuntu 20.04 wsl2) and I don't use apple hardware at all.

I still don't see a need for them to be updated in lock step, especially for Visual Studio which tends to be quite different from other toolchains, but I can see the use of the bumps occurring within the same release version of llvm if its feasible.

If we aimed to bump gcc/clang as well, would we still be in a position to get this done in plenty of time for the next release branch? I have fears that some buildbots often take many months to be updated.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list