[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 11:00:30 PST 2021

rnk added a comment.

In D114576#3153189 <https://reviews.llvm.org/D114576#3153189>, @mstorsjo wrote:

> Would it be possible to move setting of this flag to somewhere else (e.g. somewhere in Driver/ToolChains/MSVC.cpp), so that it would be picked up also when building with the gcc-style driver with `--target=*-windows-msvc`? Overall in earlier discussions, there's been mostly positive reception to making that mode more usable even if it isn't quite as supported as actually invoking `clang-cl`. (For some things, like the equivalent of the cl level `-MD`/`-MT` options, there's currently nothing available in the gcc style driver - but for a feature like this, I don't see any reason why it shouldn't be available everywhere.)

+1, that was going to be my suggestion.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list