[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Tue Nov 30 10:59:50 PST 2021

mehdi_amini added a comment.

In D114639#3162069 <https://reviews.llvm.org/D114639#3162069>, @erichkeane wrote:

> In D114639#3162032 <https://reviews.llvm.org/D114639#3162032>, @RKSimon wrote:
>
>> In D114639#3162000 <https://reviews.llvm.org/D114639#3162000>, @mehdi_amini wrote:
>>
>>> In D114639#3161303 <https://reviews.llvm.org/D114639#3161303>, @erichkeane wrote:
>>>
>>>> IMO, if we're updating the MSVC versions, we should do the same for the GCC/Clang/AppleClang versions too.  For example, GCC 5.1 is from 2015, and Clang 3.5 is from 2014.
>>>
>>> We've always handled MSVC update separately I believe, we can't just take the "last two version of MSVC" guideline and update every compiler each time.
>
> My understanding is this would only be the ~3rd time we've done this.  The last time we did this, we did them all together.

Right, but last time we did the motivation was specifically to get to c++14, while here the motivation is to drop an old MSVC according to the MSVC-specific support we intend to provide.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639