[PATCH] D114565: [InstrProf] Attach debug info to counters

Kyungwoo Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 09:58:32 PST 2021


kyulee added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:851
+      addString(AnnotationDie, dwarf::DW_AT_const_value, Value->getString());
+    else if (const auto *Expr = dyn_cast<DIExpression>(ValueOp))
+      addConstantValue(
----------------
It checks an expression but appears to apply the constant case below. Should it check a constant expression, instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114565/new/

https://reviews.llvm.org/D114565



More information about the cfe-commits mailing list