[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

C. Rayroud via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 09:34:17 PST 2021


crayroud added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:14277
+  // FIXME these tests regressed behaviour.
   // verifyFormat("T A::operator() () {}", SpaceFuncDef);
   verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef);
----------------
crayroud wrote:
> What do you think of enabling this test and to remove the space before the opening parenthesis ? As it is now the expected behaviour to have no space.
In https://reviews.llvm.org/D114696, you proposed to add an operator overloading option to SpaceBeforeParensOptions. This example: "T A::operator() () {}" should be configured from AfterFunctionDefinitionName or operator overloading ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114725/new/

https://reviews.llvm.org/D114725



More information about the cfe-commits mailing list