[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 09:15:06 PST 2021


rnk added a comment.

It looks like this Wall -> Weverything alias is from my 2017 change:
https://reviews.llvm.org/rGf9b08a382cc1e0669805991849ad69efbd4703e8

The commit message doesn't link to any bugs or any other motivating material. All I said is that this is being done for MSVC compatibility. I remember having some motivating reason, but it looks like I won't be able to find it. I see Hans thanked me for the behavior change, maybe he recalls.

Anyway, I would approve a patch to remove the alias, but I'd want to confirm with Hans that he is also on board with it, since I suspect he was the one who talked me into adding the alias. I don't have more time to follow up on this at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114651/new/

https://reviews.llvm.org/D114651



More information about the cfe-commits mailing list