[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 30 07:02:33 PST 2021


carlosgalvezp updated this revision to Diff 390708.
carlosgalvezp added a comment.

Switch to public inheritance + mutable cached data. This seems to be a valid use case <https://arne-mertz.de/2017/10/mutable/> for mutable, even though I'm not sure if there's anything against it in the LLVM coding guidelines. Looking forward to your feedback!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113422/new/

https://reviews.llvm.org/D113422

Files:
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
  clang-tools-extra/clang-tidy/GlobList.cpp
  clang-tools-extra/clang-tidy/GlobList.h
  clang-tools-extra/unittests/clang-tidy/GlobListTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113422.390708.patch
Type: text/x-patch
Size: 7090 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211130/40045daf/attachment.bin>


More information about the cfe-commits mailing list