[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Tue Nov 30 06:29:52 PST 2021

erichkeane added a comment.

In D114639#3161362 <https://reviews.llvm.org/D114639#3161362>, @aaron.ballman wrote:

> In D114639#3161303 <https://reviews.llvm.org/D114639#3161303>, @erichkeane wrote:
>
>> IMO, if we're updating the MSVC versions, we should do the same for the GCC/Clang/AppleClang versions too.  For example, GCC 5.1 is from 2015, and Clang 3.5 is from 2014.
>
> I'd be in favor of that; we could even see if we're ready to allow C++17 in the code base (which would be a pretty nice win for if init statements alone). However, it's also a bit orthogonal to this particular patch. Do you (or someone else) want to start an RFC?

I believe the C++17 RFC was already on LLVM-dev last I saw?

That said, I commented because we typically try to update the 'minimum versions' in lockstep best we can.  Bumping these versions is particularly arduous, so I'd be against trying to do it piece-meal like this, particularly as we're updating the NEWEST requirement (that is, VS2017 is newer than Clang 3.5/GCC5.1!).

Also note that we have a 'policy' for bumping versions: https://llvm.org/docs/DeveloperPolicy.html#toolchain

(From the looks of it, I think we ARE following the policy, but others should take a look).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639