[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Paul Altin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 29 23:57:32 PST 2021

paulaltin added a comment.

> LGTM, with a few small nits. It'd be nice to update the patch summary with more information about why the option is needed.

Thanks @aaron.ballman. I've made the changes to the Release Notes and added more info to the summary.

In general, would you be happy to consider other changes like this in clang-tidy? Our company uses the tool as part of our CI (and I personally find it extremely useful), but there are some checks that we have to disable entirely because they do multiple things, some of which we don't want to (or can't easily) fix. If these had options to disable part of the check then we would still be able to use the remaining parts, which would be great.

If adding more options to existing checks in clang-tidy is a direction that the developers are happy to support, then I'd be keen to submit more changes like this.



More information about the cfe-commits mailing list