[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Stella Stamenova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 29 17:03:29 PST 2021

stella.stamenova added a comment.

In D114639#3160031 <https://reviews.llvm.org/D114639#3160031>, @mehdi_amini wrote:

> In D114639#3158401 <https://reviews.llvm.org/D114639#3158401>, @RKSimon wrote:
>>> Have you checked whether there are any bots in the lab that will need to be updated?
>> I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and windows-gcebot2 machines, but there are others.
> This bot as well: https://lab.llvm.org/buildbot/#/builders/13 ; adding @stella.stamenova here.

The mlir and lldb windows bots will both need to be updated to 2019/2022. We haven't been building with 2022, so I am not sure how stable the builds will be if we moved to it (though I hope it just works). We can plan to update both bots to use 2019/2022 this week before our whole teams goes on vacation.

Comment at: clang/docs/UsersManual.rst:3546
-    cmake -G"Visual Studio 15 2017" -T LLVM ..
+    cmake -G"Visual Studio 17 2022" -T LLVM ..
compnerd wrote:
> Meinersbur wrote:
> > jhenderson wrote:
> > > RKSimon wrote:
> > > > aaron.ballman wrote:
> > > > > jhenderson wrote:
> > > > > > I think the missing space should be fixed to :)
> > > > > +1 to the missing space.
> > > > This one is confusing - it isn't in my local diff, the raw diff, or if I reapply the raw diff - it looks to have just appeared when you quote it in phab comments?
> > > The fact that the space is missing? It's missing in the current repo too.
> > It works with and without the space, like `-GNinja` and `-G Ninja` both work.
> It would be nice to mention the CMake minimum version.  I think that you need 3.22 or newer for the 2022 generator/toolset definition.
It works with or without the space, but it reads better with the space.

Comment at: clang/docs/UsersManual.rst:3546
-    cmake -G"Visual Studio 15 2017" -T LLVM ..
+    cmake -G"Visual Studio 16 2019" -T LLVM ..
jhenderson wrote:
> Maybe make this VS2022 instead, to help it last longer?
I think it makes more sense to make it 2019 because I expect most people to still be using 2019 and it's convenient to have instructions that just work. Maybe add both?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list