[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added a comment.

LGTM!



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:318
   // FIXME: This should be a static_cast.
   // C HECK-FIXES: auto s5 = static_cast<const S&>(cr);
   auto s6 = (S)cr;
----------------
salman-javed-nz wrote:
> Isn't this intentional? Isn't it saying what the CHECK-MESSAGES should look like in the future once the FIXME is done?
Ah, I guess that must be it.
(`C HECK-FIXES: ...` is a really subtle idiom for `FIXME the line above should become: ...`, but OK!)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114427/new/

https://reviews.llvm.org/D114427