[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

Bal√°zs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 29 09:04:17 PST 2021


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

I think it looks great.



================
Comment at: clang/test/Analysis/symbol-simplification-disequality-info.cpp:15-26
+  // CHECK:      "disequality_info": [
+  // CHECK-NEXT:   {
+  // CHECK-NEXT:     "class": [ "((reg_$0<int a>) + (reg_$1<int b>)) + (reg_$2<int c>)" ],
+  // CHECK-NEXT:     "disequal_to": [
+  // CHECK-NEXT:       [ "reg_$3<int d>" ]]
+  // CHECK-NEXT:   },
+  // CHECK-NEXT:   {
----------------
martong wrote:
> steakhal wrote:
> > Please try to omit unnecessary changes.
> I've made this change intentionally, so all hunks for each simplification steps are indented similarly. E.g., after the `CHECK-NEXT:` string comes 3 space characters until we the `{` character, see L16 and L34 and L51. Actually, I've made an indentation error in a previous patch, which I though I can correct now.
> 
Fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114619/new/

https://reviews.llvm.org/D114619



More information about the cfe-commits mailing list