[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 29 08:46:21 PST 2021


carlosgalvezp added a comment.

In D114427#3158405 <https://reviews.llvm.org/D114427#3158405>, @Quuxplusone wrote:

> Marking "accepted" for the record; but my checkmark means merely "I'm not intending to block this," not "I claim the authority to say you //should// land this." :)

Thanks! I was recently told that this is not recommended, as the patch no longer shows the status "Needs review to proceed" and reviewers might not be able to see it immediately in their dashboards, thus delaying review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114427/new/

https://reviews.llvm.org/D114427



More information about the cfe-commits mailing list