[PATCH] D114639: Raise the minimum Visual Studio version to VS2019
James Henderson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 29 07:55:32 PST 2021
jhenderson added inline comments.
================
Comment at: clang/docs/UsersManual.rst:3546
- cmake -G"Visual Studio 15 2017" -T LLVM ..
+ cmake -G"Visual Studio 17 2022" -T LLVM ..
----------------
RKSimon wrote:
> aaron.ballman wrote:
> > jhenderson wrote:
> > > I think the missing space should be fixed to :)
> > +1 to the missing space.
> This one is confusing - it isn't in my local diff, the raw diff, or if I reapply the raw diff - it looks to have just appeared when you quote it in phab comments?
The fact that the space is missing? It's missing in the current repo too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114639/new/
https://reviews.llvm.org/D114639
More information about the cfe-commits
mailing list