[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Mon Nov 29 05:35:58 PST 2021

aaron.ballman added a comment.

Have you checked whether there are any bots in the lab that will need to be updated?

================
Comment at: clang/docs/UsersManual.rst:3546

-    cmake -G"Visual Studio 15 2017" -T LLVM ..
+    cmake -G"Visual Studio 17 2022" -T LLVM ..

----------------
jhenderson wrote:
> I think the missing space should be fixed to :)
+1 to the missing space.

================
Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:17-18
+# _MSC_VER == 1929 MSVC++ 14.29 Visual Studio 2019 Version 16.10 & 16.11
+set(MSVC_MIN 19.20)
+set(MSVC_SOFT_ERROR 19.29)

----------------
I'm a bit less certain that this is reasonable. 16.11.0 is from August 2021, which seems incredibly new for giving soft errors on.

================
Comment at: llvm/include/llvm/Support/Compiler.h:106-108
 /// Sadly, this is separate from just rvalue reference support because GCC
 /// and MSVC implemented this later than everything else. This appears to be
 /// corrected in MSVC 2019 but not MSVC 2017.
----------------
RKSimon wrote:
> jhenderson wrote:
> > RKSimon wrote:
> > > jhenderson wrote:
> > > > Does this comment need changing?
> > > An even bigger question is - can we get rid of the LLVM_HAS_RVALUE_REFERENCE_THIS define entirely now? Either as part of this patch or as a followup
> > Yeah, another patch entirely to sort this would be fine.
> I'll add a FIXME to this patch
+1; FWIW, the last time we tried to get rid of this, the only thing we could realistically do was remove it and see how the bots/community reacted. Doing that in a follow-up patch seems like a good idea to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639