[PATCH] D114639: Raise the minimum Visual Studio version to VS2019
Simon Pilgrim via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 29 01:28:51 PST 2021
RKSimon added inline comments.
Comment at: llvm/include/llvm/Support/Compiler.h:106-108
/// Sadly, this is separate from just rvalue reference support because GCC
/// and MSVC implemented this later than everything else. This appears to be
/// corrected in MSVC 2019 but not MSVC 2017.
> RKSimon wrote:
> > jhenderson wrote:
> > > Does this comment need changing?
> > An even bigger question is - can we get rid of the LLVM_HAS_RVALUE_REFERENCE_THIS define entirely now? Either as part of this patch or as a followup
> Yeah, another patch entirely to sort this would be fine.
I'll add a FIXME to this patch
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits