[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Paul Altin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 26 20:03:44 PST 2021


paulaltin added a comment.

Thanks for your help @salman-javed-nz.

> Build is failing because you don't have a CHECK-MESSAGES-DISABLED line anywhere in the file.
> You could change // DISABLED: to // CHECK-MESSAGES-DISABLED-NOT: and check for the absence of the check warning.

Instead of doing this, I added another test function which checks that floating-point to integer warnings still work when this option is enabled. This seems to be more in line with what other option tests do (e.g. cppcoreguidelines-narrowing-conversions-equivalentbitwidth-option.cpp).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112881/new/

https://reviews.llvm.org/D112881



More information about the cfe-commits mailing list