[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 26 13:39:45 PST 2021
aaronpuchert added inline comments.
================
Comment at: clang/lib/AST/CommentSema.cpp:135-137
+ if (const auto *VD = dyn_cast<VarDecl>(ThisDeclInfo->CurrentDecl))
+ if (VD->getType()->isFunctionPointerType())
+ return;
----------------
Something might be wrong here anyway: the [documentation](https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/HeaderDoc/tags/tags.html) says that `@callback`
> Specifies the name and description of a callback field in a structure.
But we're looking for a `VarDecl` instead of a `FieldDecl`. Is somebody still around who knows HeaderDoc? Seems like Apple doesn't care any longer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113795/new/
https://reviews.llvm.org/D113795
More information about the cfe-commits
mailing list