[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 26 06:43:23 PST 2021


steakhal added a comment.

In D113558#3154967 <https://reviews.llvm.org/D113558#3154967>, @whisperity wrote:

> I'm not sure if it is a good idea to merge things on a Friday, but I am comfortable with this, let's get the check crash less.

I've run this on a few projects and it did not introduce new crashes. I plan to commit this on Monday.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113558/new/

https://reviews.llvm.org/D113558



More information about the cfe-commits mailing list