[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 26 02:03:12 PST 2021


lebedev.ri resigned from this revision.
lebedev.ri added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:40
                     const MacroDirective *MD) override {
     if (SM.isWrittenInBuiltinFile(MD->getLocation()) ||
         MD->getMacroInfo()->isUsedForHeaderGuard() ||
----------------
Can that macro be defined elsewhere so this check fires instead of having to special-case the macro here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114579/new/

https://reviews.llvm.org/D114579



More information about the cfe-commits mailing list