[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

Thu Nov 25 09:07:48 PST 2021

jrtc27 added a comment.

In D114533#3154225 <https://reviews.llvm.org/D114533#3154225>, @arsenm wrote:

> In D114533#3153924 <https://reviews.llvm.org/D114533#3153924>, @jrtc27 wrote:
>
>> This seems like it should not apply to non-integral address spaces?
>
> No, it shouldn’t care about the individual address spaces. It’s a reinterpret of the bits, the type meanings don’t matter

Well, they absolutely do for us downstream, but we also don't use the non-integral address space feature, since it didn't exist when our fork started and also has overly restrictive semantics. Normally the places we need to stop these kinds of casts/reinterpretations are a subset of those for non-integral address spaces, but maybe this is one of those exceptions then. I certainly have no clue about what the non-integral address spaces are actually used for and mean :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114533/new/

https://reviews.llvm.org/D114533