[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added a comment.

This seems like it should not apply to non-integral address spaces?



================
Comment at: llvm/docs/LangRef.rst:10999
+with this instruction. Conversion of pointers to different address spaces 
+are legal, but may result in undefined behaviour where such a reinterpretation 
+of bits is not supported by the target. To convert pointers to other 
----------------
This should be illegal, not legal and undefined, you really want the IR verifier to be able to pick up on this at least, if not an assertion at creation time


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:729
 
+  /// This method can e used to determine if a cast from SrcTy to DstTy using
+  /// Opcode op and DataLayout DL is valid or not
----------------
Typo "e"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114533/new/

https://reviews.llvm.org/D114533