[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 25 03:09:37 PST 2021


steakhal updated this revision to Diff 389711.
steakhal marked an inline comment as done.
steakhal added a comment.

Added the `test_parameter_passing()` tests, demonstrating the implicit conversion triggered by parameter passing.
It turns out my previous revision suppressed a useful report.
Now, I fixed that and we get a warning for `take<int>(x.id) // warn` when `x` is `CompleteBitfield` with `32` bitwidth.
Aside from this, no behavioral change happened compared to the previous revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114105/new/

https://reviews.llvm.org/D114105

Files:
  clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114105.389711.patch
Type: text/x-patch
Size: 9389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211125/a783a377/attachment-0001.bin>


More information about the cfe-commits mailing list