[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Anshil Gandhi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 24 16:13:20 PST 2021


gandhi21299 added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:5536
+    // GCC does not enforce these rules for GNU atomics, but we do, because if
+    // we didn't it would be very confusing. FIXME:  For whom? How so?
     auto IsAllowedValueType = [&](QualType ValType) {
----------------
Is this change really necessary? It is a confusing comment and probably not too helpful for the developers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114025/new/

https://reviews.llvm.org/D114025



More information about the cfe-commits mailing list