[PATCH] D113917: Add infrastructure to support matcher names.

James King via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 24 14:34:43 PST 2021


jcking1034 added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:152
+  }
+MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgument)
+MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgumentLoc)
----------------
hokein wrote:
> These are types that are not covered in the above gen .inc files. I wonder is there a way to verify this list is complete? 
I compared this list to other portions of the code where a similar pattern was used, and have just added specializations for OMP-related nodes. In these other portions of code, I didn't notice anything that verifies completeness, but I agree that this would be preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113917/new/

https://reviews.llvm.org/D113917



More information about the cfe-commits mailing list