[PATCH] D113925: [HIP] Add HIP scope atomic operations

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:5587
     // the GNU atomics specification, but we enforce it, because if we didn't it
     // would be very confusing. FIXME:  For whom? How so?
     Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_trivial_copy)
----------------
I'm confused about what's happening here.  You're editing comments to make more tendentious claims, and then adding FIXMEs to make charged questions about your own claims?  Did you consider just not editing the comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113925/new/

https://reviews.llvm.org/D113925