[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 24 13:25:04 PST 2021


Quuxplusone added inline comments.


================
Comment at: clang/docs/ThreadSafetyAnalysis.rst:471
 
-  + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax.
+  + ``-Wthread-safety-attributes``: Validation checks on attribute syntax.
   + ``-Wthread-safety-analysis``: The core analysis.
----------------
I'd just say "Rejects invalid attribute syntax." But also
- surely this is totally obvious, that invalid syntax causes an error? why do we even need to write this?
- line 469 says "three" but then there are four bullet points


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114562/new/

https://reviews.llvm.org/D114562



More information about the cfe-commits mailing list