[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

[Felix Berger via Phabricator via cfe-commits]

flx added a comment.

This looks great, but goes past my knowledge of the AST API :) While the existing and new test coverage provides good confidence, one other reviewer taking look would be good.



================
Comment at: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp:112
+      switch (
+          E->ClassifyModifiable(Finder->getASTContext(), Loc).getModifiable()) {
+      case Expr::Classification::CM_Untested:
----------------
Reuse Ctx here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114539/new/

https://reviews.llvm.org/D114539