[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 24 04:33:03 PST 2021


mstorsjo added a comment.

Looks overall ok, without diving in very deep, except for this one change that seemed unrelated.



================
Comment at: libunwind/src/Unwind-EHABI.cpp:312
               uint8_t registers = getByte(data, offset++);
-              if (registers & 0xf0 || !registers)
+              if (registers & 0xf0)
                 return _URC_FAILURE;
----------------
This particular change looks unrelated to the rest, on a quick glance


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112430/new/

https://reviews.llvm.org/D112430



More information about the cfe-commits mailing list