[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

> this still seems like a half a solution

I see, thanks for the input! I took configuration into account due to the concerns raised in previous patch attempts and in the RFC. I believe both use cases are valid so it makes sense to me to support both as independent opt-in flags. What do you think, @aaron.ballman ?

Out of the scope of this patch, I think it's important to document what exactly we mean by "alias". Users currently think that they are "interchangeable" and they are not aware that they are configured with different options by default, producing different results. For example, the "cppcoreguidelines-non-private-members-in-classes" is less strict than "misc-non-private-members-in-classes".

As I was writing this patch, I was thinking that another possibility is to add an option for clang-tidy to print out the alias checks, if we don't want to disable them. As a user, my main goal is to get an answer to the question: "what checks can I safely disable to speed up clang-tidy without losing coverage"? If clang-tidy can print this list for me, I can copy-paste it into my .clang-tidy file and be happy. I don't want to manually look at the HTML docs (which are manually-written and thus error-prone) nor at the source code to find this out, each time I update clang-tidy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114317/new/

https://reviews.llvm.org/D114317