[PATCH] D114394: Compile-time computation of string attribute hashes

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/IR/Attributes.cpp:125
   FoldingSetNodeID ID;
-  ID.AddString(Kind);
+  ID.AddString(Kind.value());
   if (!Val.empty()) ID.AddString(Val);
----------------
Carrying over my comment from the original revision: it seem that you're ever only using the StringRef from the Kind in this function.
If so changing the API to use an AttributeKey seems pessimizing to me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114394/new/

https://reviews.llvm.org/D114394