[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 23 19:25:50 PST 2021


vsapsai updated this revision to Diff 389374.
vsapsai added a comment.

Fix some failing tests to demonstrate the magnitued of changes better.

In some places check if a decl is deserialized successfully as it's not guaranteed.
Also tried to make sure a module is marked as visible *before* we try to deserialize its decls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114411/new/

https://reviews.llvm.org/D114411

Files:
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Sema/SemaModule.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTReaderDecl.cpp
  clang/lib/Serialization/ASTWriterDecl.cpp
  clang/test/Modules/ambiguous-enum-lookup.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114411.389374.patch
Type: text/x-patch
Size: 9821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211124/94173045/attachment-0001.bin>


More information about the cfe-commits mailing list