[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

In D114317#3149504 <https://reviews.llvm.org/D114317#3149504>, @salman-javed-nz wrote:

> What would you say are the key differences between this patch differ and previous attempts, e.g. https://reviews.llvm.org/D72566? How does this patch address the concerns raised in the previous reviews?

The key differences are:

- It has been previously discussed and agreed upon via RFC in the mailing list, as requested as a comment in the previous patch.

- Check developers do not need to manually specify which check is aliasing which check. It's automated and transparent, thus less burden on check developers and less possibility for errors.

- Only aliases with the same configuration (perfect aliases) are removed. The patch you mention would run only one instance with it's configuration, so "aliases with different configuration" would incorrectly not be run (if I read the commit message currently).

I don't have a strong opinion as to which patch to use to continue this work, I just would like work to make it happen. It's been a standing issue for quite a long time :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114317/new/

https://reviews.llvm.org/D114317