[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54
 
+void verifyIncomingMultiFile(std::string SourceExt, std::string HeaderExt,
+                             Annotations &CalleeH, Annotations &Caller1H,
----------------
nridge wrote:
> nit: rather than passing `std::string` by value, let's use `llvm::StringRef`
> 
> (`const std::string&` would also be fine, but I think `llvm::StringRef` is more conventional in this codebase)
i am not sure if these helpers makes tests easier to read (i believe they're actually making it harder).

please inline them back. if we want to have better infrastructure for testing this, we need to do it in its own patch (and I definitely agree that we need a better infra for testing here. but we need to think about something that can generalize rather than forcing a particular pattern).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114058/new/

https://reviews.llvm.org/D114058